https://bugzilla.redhat.com/show_bug.cgi?id=1902081



--- Comment #2 from Mukundan Ragavan <[email protected]> ---
Thanks for the review.

(In reply to Andy Mender from comment #1)
> > %package -n     python3-%{pypi_name}
> > Summary:        %{summary}
> > %{?python_provide:%python_provide python3-%{pypi_name}}
> 
> The %py_provides macro should be used here.
> 

Done in the updated spec file.

> > %check
> > PYTHONPATH=%{buildroot}%{python3_sitelib} pytest-3 -v -k 'not 
> > test_many_parallel_notebooks'
> 
> I'm not familiar with this invocation, but could you try using the %pytest
> macro instead?
> 

I had some problems with other packages in the past and someone in the
python-sig came up with this solution.

But, in this case, %pytest macro works fine (as expected; I guess since it
contains pythonpath already). 

> Some of the description lines are a little too long. Make sure they don't
> exceed 80 characters:

Will fix during import.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to