https://bugzilla.redhat.com/show_bug.cgi?id=1904172
Mikel Olasagasti Uranga <mi...@olasagasti.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(mikel@olasagasti. |
|info) |
--- Comment #3 from Mikel Olasagasti Uranga <mi...@olasagasti.info> ---
Thanks for the review Michel Alexandre, I learned new things here.
Updated spec and srpm:
Spec URL: https://mikel.olasagasti.info/tmp/fedora/endlessh.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/endlessh-1.1-2.fc33.src.rpm
- Added missing %dir %{_sysconfdir}/%{name}
- Changed systemd to Req and added BR to systemd-rpm-macros
- Registered systemd unit
- Patched Makefile with sed during %install to use %{optflags}
- Change $RPM_BUILD_ROOT to %{buildroot} to use one style
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
