https://bugzilla.redhat.com/show_bug.cgi?id=1903686
--- Comment #2 from Andy Mender <andymenderu...@gmail.com> ---
> Release: 2.%{git_suffix}%{?dist}
> License: GPLv2+
> Group: Development/Libraries
- The Group field is obsolete.
- Not sure about the license. The project doesn't have a license file (the
patch you submitted adds it, in fact) and the text I see in some files would
fit "GPL+ with exceptions" or "GPLv2 with exceptions" more, I think:
https://github.com/alire-project/xmlezout/blob/master/mckae-xml-ez_out-generic_medium.adb
> URL: https://github.com/alire-project/xmlezout
> Source0:
> https://github.com/alire-project/%{name}/archive/%{git_commit}/%{name}-%{version}.tar.gz
- You can use the URL in the Source0 field with the %{url} macro.
- The downloaded archive is actually "%{name}-%{git_commit}.tar.gz" so an alias
might be needed. Or I'm doing something wrong :(.
> BuildRequires: gprbuild gcc-gnat
Could you split these into separate lines?
> %files
> %defattr(-,root,root,-)
Setting permissions in %files is no longer needed.
I'll wait with a full review until the PR you submitted is in.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
