https://bugzilla.redhat.com/show_bug.cgi?id=1916936



--- Comment #5 from Neal Gompa <[email protected]> ---
> %global debug_package %{nil}

Why are you doing this?

> Provides:       %{name} = %{version}-%{release}

This is redundant, as RPM autogenerates this already.

> cmake -G Ninja -DCMAKE_INSTALL_PREFIX=%{buildroot}%{_usr} 
> -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ .
> ninja
> [..]
> ninja install


Why isn't this using the CMake macros, like so?

> %cmake -G Ninja
> %cmake_build
> [..]
> %cmake_install

> %post -p /sbin/ldconfig
> %postun -p /sbin/ldconfig

This is unneeded for EPEL8+ and Fedora. If you need EPEL7 compatibility, use
"%ldconfig_scriptlets" instead:
https://fedoraproject.org/wiki/EPEL:Packaging#Shared_Libraries


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to