Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=655954

Paul W. Frields <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |needinfo?(peter.bo...@gmail
                   |                            |.com)

--- Comment #2 from Paul W. Frields <[email protected]> 2010-12-17 07:51:52 
EST ---
Peter, when you include rpmlint output, please remember to include it for the
binary RPM as well.

$ rpmlint rpmbuild/SPECS/drupal6-token.spec drupal6-token-1.15-1.fc14.src.rpm
rpmbuild/RPMS/noarch/drupal6-token-1.15-1.fc14.noarch.rpm 
drupal6-token.noarch: W: incoherent-version-in-changelog 1.15 ['1.15-1.fc14',
'1.15-1']
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

* Fix your %changelog entry. This was a problem in another spec file also, if I
recall correctly.

* Your definition of %drupaldir at the top won't work in Fedora Rawhide/F-15
and should probably use guidance I provided for you in one of your other
package review bugs.

I don't see any other glaring problems, just repost when you have these fixed
and I can complete a full review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to