https://bugzilla.redhat.com/show_bug.cgi?id=1922774

Jitka Plesnikova <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <[email protected]> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Please add 'coreutils', it is needed for macro %{_fixperms}

$ rpm -qp --requires perl-Test-DiagINC-0.008-1.fc34.noarch.rpm | sort | uniq -c
| grep -v rpmlib
      1 perl(:MODULE_COMPAT_5.32.1)
      1 perl(:VERSION) >= 5.6.0
Binary requires 
FIX: Please add following run-requires, they are not found by generators:
     - perl(B)
     - perl(Cwd)
     - perl(File::Spec)
     - perl(strict)
     - perl(warnings)


$ rpm -qp --provides perl-Test-DiagINC-0.008-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(Test::DiagINC) = 0.008
      1 perl-Test-DiagINC = 0.008-1.fc34
Binary provides are Ok.

$ rpmlint ./perl-Test-DiagINC*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items. 

Resolution:
Approved


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to