https://bugzilla.redhat.com/show_bug.cgi?id=1918078



--- Comment #2 from Adam Jackson <[email protected]> ---
(In reply to Artur Frenszek-Iwicki from comment #1)
> >Source0:        https://invisible-island.net/datafiles/release/luit.tar.gz
> This will always point to the latest release, which makes reproducing builds
> harder.
> How about using "ftp://ftp.invisible-island.net/luit/luit-%{version}.tgz";
> instead?

ftp isn't exactly a reliable step, if "reproducing the build" is an issue. I
found what looks like a stable https url with the version number though.

> >%install
> >rm -rf $RPM_BUILD_ROOT
> Don't remove the buildroot at start of %install.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

Sure, done. spec and srpm updated, same URLs as above.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to