https://bugzilla.redhat.com/show_bug.cgi?id=1928969

Kevin Fenzi <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #9 from Kevin Fenzi <[email protected]> ---
Looks good to me, this package is APPROVED. 

Before you import it tho, it might be nice to add some comments to the crazy
libjabber areas? explain why we exclude (don't want other packages to get it
from us), why we copy in build (we have to link against it), why we make a
ld.so.conf.d file (to allow us to use the private lib at runtime). Just to
avoid confusion from people. :)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to