https://bugzilla.redhat.com/show_bug.cgi?id=1936080



--- Comment #3 from Timothée Floure <[email protected]> ---
Spec URL: https://paste.sr.ht/blob/f2c0c80d7db747ced515033fbadcf2eb1aa300ef
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/8079/64198079/hikari-2.2.2-3.fc33.src.rpm

> - Specify set_build_flags to use Fedora default build flags:

Done.

>  - Own these directories:

Done.

>  - Mark this file as noreplace:

Done.

>  - Should be 2021 here:

Done.

>  - It seems hikari needs seituid permissions:

It doesn't, as Aleksei mentioned. I removed it.

> I believe the canonical way to do that in rpm spec is `%attr(0755,-,-) 
> %{_bindir}/%{name}` in %files section.

Didn't know about this, thanks!

> Timothée, do you mind delaying import of `hikari` until f34 final freeze?
> wlroots 0.13.0 ETA is end of March and I'm not sure if we will be able to get 
> compatible release of hikari fast enough to meet f34 update deadlines.

Ack, I'll ask my upstream what it think about wlroots 0.13.0 - but don't mind
keeping it in rawhide if needed.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to