https://bugzilla.redhat.com/show_bug.cgi?id=1942392
--- Comment #8 from Sergio Lopez <[email protected]> --- (In reply to Connor Kuehl from comment #7) > (In reply to Fabiano Fidêncio from comment #6) > > [..] > > [!]: License file installed when any subpackage combination is installed. > > Sergio, license is only being installed as part of the > > rust-vmm-sys-util-devel package. > > I think the root `rust-vmm-sys-util-devel` is required by the other > subfeature versions, so running `dnf install rust-vmm-sys-util+serde-devel` > should result in rust-vmm-sys-util-devel being installed with the license. > Is that sufficient? I've just checked and all subpackages depend on the main one via "crate(vmm-sys-util)": [slp@fedora noarch]$ rpm -qpR rust-vmm-sys-util+default-devel-0.8.0-1.fc34.noarch.rpm cargo crate(vmm-sys-util) = 0.8.0 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 [slp@fedora noarch]$ rpm -qpR rust-vmm-sys-util+serde-devel-0.8.0-1.fc34.noarch.rpm cargo crate(serde/default) >= 1.0.27 crate(vmm-sys-util) = 0.8.0 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 [slp@fedora noarch]$ rpm -qpR rust-vmm-sys-util+serde_derive-devel-0.8.0-1.fc34.noarch.rpm cargo crate(serde_derive/default) >= 1.0.27 crate(vmm-sys-util) = 0.8.0 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 [slp@fedora noarch]$ rpm -qpR rust-vmm-sys-util+with-serde-devel-0.8.0-1.fc34.noarch.rpm cargo crate(serde/default) >= 1.0.27 crate(serde_derive/default) >= 1.0.27 crate(vmm-sys-util) = 0.8.0 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 This also seems to be what other packaged rust-crates do, such as rust-memmap. > > [..] > > [?]: Package functions as described. > > Sergio, I haven't tested the package, I'd appreciate if Connor could > > do. > > I have a package that only transiently depends on vmm-sys-util for unit > tests, but a lot of the other required packages aren't packaged for Fedora > yet since they depend on this one. So I think it would be nontrivial for me > to position my other package to test this library. The unit tests that run > for this package are all passing, which is good enough for me. FWIW, I have a second package ready for submission (vm-memory) that depends on vmm-sys-util, and passes its own tests fine. Given that we're just shipping some sources in the package, I think it should be fine. Thank you both! Sergio. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
