https://bugzilla.redhat.com/show_bug.cgi?id=1944117

Parag AN(पराग) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #5 from Parag AN(पराग) <[email protected]> ---
Suggestions:
1) You can simplify cp commands as given in
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps
just use "cp -p"

2) README.md is not needed as it contains only upstream project URL but I am
fine if you decide to package it


Observations:
1) Source0: checksum is failing. In case in future upstream can release on
github, this package should move to github archive as Source0:
2) LICENSE file is GPLv3+ but as source file header shows GPLv3, its correct to
use License tag as GPLv3

This package is APPROVED now.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to