https://bugzilla.redhat.com/show_bug.cgi?id=1953508

Neal Gompa <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
                   |needinfo?([email protected] |
                   |m)                          |



--- Comment #6 from Neal Gompa <[email protected]> ---
Review notes:

* Package follows Fedora Packaging Guidelines
* Package licensing is correct and license files are correctly installs
* Package builds and installs with no serious issues from rpmlint

There was one issue though:

* Missing gcc and ninja-build BRs:
https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

However, I'm okay with you fixing this on import.

PACKAGE APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to