https://bugzilla.redhat.com/show_bug.cgi?id=1964682
--- Comment #3 from Joshua Clayton <stillcompil...@gmail.com> --- Thank you for that very thorough review. One item especially, a proper download URL for github is one I've wrestled with and thought I had come up with the best compromise. Thanks for enlightening me. I'm super pleased that you're bumping paho-c. I believe I've fixed all the problems you have laid out, with the exception of running the upstream tests as part of build. I've updated to 1.2.0 (which does not need to be patched), and modified the build process, dependencies and files as requested. The tests can be made to pass, but they require network access and a running MQTT broker, or some of the tests fail. I have adde the tests to a private branch, and woudl be happy to include them if the caveats can be met. They do take a while, due to testing timeouts. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
