https://bugzilla.redhat.com/show_bug.cgi?id=1964787

Neal Gompa <ngomp...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(ngomp...@gmail.co |
                   |m)                          |
                   |needinfo?(ngomp...@gmail.co |
                   |m)                          |



--- Comment #19 from Neal Gompa <ngomp...@gmail.com> ---
> Source0:      
> https://github.com/westerndigitalcorporation/%{name}/archive/refs/tags/v%{version}.tar.gz

You should just simplify Source0 to
"%{url}/archive/v%{version}/%{name}-%{version}.tar.gz"

Cf.
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags

> %ldconfig_scriptlets

Drop this, we don't need it in any stable Fedora release, and it's only needed
for EPEL7, which this isn't targeted for.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to