https://bugzilla.redhat.com/show_bug.cgi?id=1968655



--- Comment #4 from Carl George 🤠 <[email protected]> ---
There is a duplicate line for the main license file, it only needs to be
included once.

    -%license license
     %license license license.boost


The license breakdown comment that is required by the guidelines is missing.

    +# The entire source code is GPLv3+ except cmake_modules/Findhidapi.cmake
which is Boost
     License:        GPLv3+ and Boost


There is still an explicit require on hidapi, and now another one on glibc. 
Those aren't allowed.

    -Requires:       hidapi
    -Requires:       glibc


This spec file is really close to done, just wrap up those last few things.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to