https://bugzilla.redhat.com/show_bug.cgi?id=1967805

Robert-André Mauchin 🐧 <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #3 from Robert-André Mauchin 🐧 <[email protected]> ---
 - this should be called web-ext rather than nodejs-web-ext

 - coffee-script seems to have been adopted

 - License:        MPLv2.0 and GPLv3.0 and MIT

GPLv3 is the correct license shorthand, not GPLv3.0

 - No checks are run here, there should be a test suite:

%check
%nodejs_symlink_deps --check
%{__nodejs} -e 'require("./")'
# Setup bundled dev node_modules for testing
#   Note: this cannot be in %%prep or the dev node_modules
#            can get pulled into the regular rpm
tar xfz %{SOURCE2}
pushd node_modules
ln -sf  ../node_modules_dev/* .
popd
pushd node_modules/.bin
ln -sf  ../../node_modules_dev/.bin/* .
popd


 - I can't access the SRPM from Pagure, can you put it on your Fedorapeople
space instead?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to