https://bugzilla.redhat.com/show_bug.cgi?id=1976483

Miro Hrončok <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from Miro Hrončok <[email protected]> ---
Spec sanity:

1) Consider using and URL that contains name:

Source0:        %{url}/archive/%{version}/%{pypi_name}-%{version}.tar.gz

It plays much nicer with other tarballs when %_sourcedir is a common location
on packager's machine.


2) %{?python_provide:...} is deprecated and SHOULD NOT be used, see
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro
 


Other than that, looks sane.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to