https://bugzilla.redhat.com/show_bug.cgi?id=1979275



--- Comment #6 from Miro HronĨok <[email protected]> ---
Spec sanity:


> URL:            https://github.com/python-lsp/%{name}

I find this rather hard to hrasp, especially since the entire spec file rather
uses %{short_name}. COnsidder expanding the URL fully, so it is easier to copy
paste for whover needs to read it from the spec.


> Source0:        
> https://files.pythonhosted.org/packages/source/p/%{name}/%{name}-%{version}.tar.gz

Please, use %{pypi_source} instead. The exact URL is not considered
future-stable.


> %description
> %_description
> ...
> %description -n python3-%{short_name}
> %_description

The descriptions now start with a newline. Use this instead to avoid it:

  %description %_description
  %description -n python3-%{short_name} %_description



> # Remove bundled egg-info
> rm -rf %{pypi_name}.egg-info

This is not required with pyproject macros. In fact, it is most likely not ever
required.



> %check
> pytest

Is it possible to use the documented %pytest macro instead?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to