https://bugzilla.redhat.com/show_bug.cgi?id=1970460



--- Comment #8 from Petr Pisar <[email protected]> ---
TODO: You can remove the parenthesis from the License value.
TODO: Do not provide "%{name}%{?_isa} = %{version}-%{release}" explicitly. It's
is created automatically.

The package builds in F35
(https://koji.fedoraproject.org/koji/taskinfo?taskID=71589206). Ok.

$ rpmlint perl-GooCanvas2-CairoTypes.spec
../SRPMS/perl-GooCanvas2-CairoTypes-0.001-4.fc35.src.rpm
../RPMS/x86_64/perl-GooCanvas2-CairoTypes-*
========================================================== rpmlint session
starts =========================================================
rpmlint: 2.0.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 6

perl-GooCanvas2-CairoTypes-debuginfo.x86_64: W: unstripped-binary-or-object
/usr/lib/debug/usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so-0.001-4.fc35.x86_64.debug
perl-GooCanvas2-CairoTypes-debuginfo.x86_64: E:
shared-library-without-dependency-information
/usr/lib/debug/usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so-0.001-4.fc35.x86_64.debug
perl-GooCanvas2-CairoTypes-debuginfo.x86_64: W: no-documentation
perl-GooCanvas2-CairoTypes-debugsource.x86_64: W: no-documentation
perl-GooCanvas2-CairoTypes-debuginfo.x86_64: W: dangling-relative-symlink
/usr/lib/debug/.build-id/b7/b279c41dc887a2504a92be0e309ee258a3edb2
../../../.build-id/b7/b279c41dc887a2504a92be0e309ee258a3edb2
=========================== 5 packages and 1 specfiles checked; 1 errors, 4
warnings, 1 badness; has taken 0.9 s ==========================
rpmlint is Ok.

$ rpm -q -lv -p
../RPMS/x86_64/perl-GooCanvas2-CairoTypes-0.001-4.fc35.x86_64.rpm 
drwxr-xr-x    2 root     root                        0 Jul  9 15:42
/usr/lib/.build-id
drwxr-xr-x    2 root     root                        0 Jul  9 15:42
/usr/lib/.build-id/b7
lrwxrwxrwx    1 root     root                       80 Jul  9 15:42
/usr/lib/.build-id/b7/b279c41dc887a2504a92be0e309ee258a3edb2 ->
../../../../usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so
drwxr-xr-x    2 root     root                        0 Jul  9 15:42
/usr/lib64/perl5/vendor_perl/GooCanvas2
-rw-r--r--    1 root     root                     1930 Feb 19 01:34
/usr/lib64/perl5/vendor_perl/GooCanvas2/CairoTypes.pm
drwxr-xr-x    2 root     root                        0 Jul  9 15:42
/usr/lib64/perl5/vendor_perl/auto/GooCanvas2
drwxr-xr-x    2 root     root                        0 Jul  9 15:42
/usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes
-rwxr-xr-x    1 root     root                    15232 Jul  9 15:42
/usr/lib64/perl5/vendor_perl/auto/GooCanvas2/CairoTypes/CairoTypes.so
drwxr-xr-x    2 root     root                        0 Jul  9 15:42
/usr/share/doc/perl-GooCanvas2-CairoTypes
-rw-r--r--    1 root     root                       85 Feb 19 01:34
/usr/share/doc/perl-GooCanvas2-CairoTypes/Changes
-rw-r--r--    1 root     root                     1966 Feb 19 01:34
/usr/share/doc/perl-GooCanvas2-CairoTypes/README
drwxr-xr-x    2 root     root                        0 Jul  9 15:42
/usr/share/licenses/perl-GooCanvas2-CairoTypes
-rw-r--r--    1 root     root                    18331 Feb 19 01:34
/usr/share/licenses/perl-GooCanvas2-CairoTypes/LICENSE
-rw-r--r--    1 root     root                     2052 Jul  9 15:42
/usr/share/man/man3/GooCanvas2::CairoTypes.3pm.gz

$ rpm -q -lv -p
../RPMS/x86_64/perl-GooCanvas2-CairoTypes-devel-0.001-4.fc35.x86_64.rpm 
-rw-r--r--    1 root     root                     1930 Feb 19 01:34
/usr/lib64/perl5/vendor_perl/GooCanvas2/CairoTypes.pm
-rw-r--r--    1 root     root                     2052 Jul  9 15:42
/usr/share/man/man3/GooCanvas2::CairoTypes.3pm.gz

FIX: The devel subpackage is a subset of the main package. Please do not create
the devel subpackage. It has no meaning.

$ resolvedeps f35-build
../RPMS/x86_64/perl-GooCanvas2-CairoTypes{,-devel}-0.001-4.fc35.x86_64.rpm 
Binary dependencies are resolvable. Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct the 'FIX' item, consider fixing the 'TODO' items, and provide a
new spec file.
Resolution: Package NOT approved.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to