https://bugzilla.redhat.com/show_bug.cgi?id=1981739



--- Comment #2 from Miroslav Suchý <[email protected]> ---
The description should end with a full stop. Unlike from summary. And the name
of package should not be repeated in Summary. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description

--

Are any of BuildRequires needed just for %check? If yes then I recommend
splitting them by comment like:

BuildRequires: gcc
# These are needed just for test
BuildRequires: some-test-package

This helps any future bootstrapping.

--

- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_devel_packages

--

lee.x86_64: W: shared-lib-calls-exit /usr/lib64/libkleeRuntest.so.1.0
exit@GLIBC_2.2.5

--

klee.x86_64: W: no-manual-page-for-binary gen-bout
klee.x86_64: W: no-manual-page-for-binary gen-random-bout
klee.x86_64: W: no-manual-page-for-binary kleaver
klee.x86_64: W: no-manual-page-for-binary klee
klee.x86_64: W: no-manual-page-for-binary klee-replay
klee.x86_64: W: no-manual-page-for-binary klee-stats
klee.x86_64: W: no-manual-page-for-binary klee-zesti                            
klee.x86_64: W: no-manual-page-for-binary ktest-tool

While this is not a blocker, it would be nice to have one. Probably co-operate
with upstream on this.

--

BTW most of these issue I found using `/usr/bin/fedora-review -b 1981739`.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to