https://bugzilla.redhat.com/show_bug.cgi?id=1984114

Fabio Valentini <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review+



--- Comment #1 from Fabio Valentini <[email protected]> ---
Package generated with rust2rpm, which simplifies the review.

- package builds and installs without errors on rawhide
- latest version is packaged
- license (MIT) is correct and acceptable for Fedora
- license file is shipped with %license
- consistent with Rust Packaging Guidelines
- tests disabled with good, documented reason

Package APPROVED.

Two additional reminders:

- add a small comment why you're patching out dependencies
  (i.e. "drop windows-specific dependencies" or something like that)
- don't forget to request f34 branch and build the package there too,
  otherwise I can't update dua-cli and other stuff there


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to