https://bugzilla.redhat.com/show_bug.cgi?id=1987564
Artur Frenszek-Iwicki <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from Artur Frenszek-Iwicki <[email protected]> --- > Spec URL: > https://github.com/OEntegrasyon/MongoDB_incremental_backup/releases/tag/mongoInc-backup > SRPM URL: > https://github.com/OEntegrasyon/MongoDB_incremental_backup/releases/tag/mongoInc-backup This is a link to a GitHub downloads page. Please use direct links to the "raw" .spec and .src.rpm files. > License: GNU GNU is a free software project, not the name of a license. Looking at the sources, you meant the GNU General Public License, version 3. Use "GPLv3" here. https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses > Group: System > Packager: Ergün Elvan Bilsel Not used in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections > mkdir -p $RPM_BUILD_ROOT/etc/mongobackup/ > mkdir -p $RPM_BUILD_ROOT/usr/local/bin/ > mkdir -p $RPM_BUILD_ROOT/usr/share/licenses/mongoInc-backup/ > mkdir -p $RPM_BUILD_ROOT/usr/share/doc/mongoInc-backup/ Do not use hard-coded paths. You should use the appropriate RPM macros instead, e.g. '/usr/share' -> '%{_datadir}'. https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#_macros_for_paths_set_and_used_by_build_systems > cp > /home/ergunbilsel/PycharmProjects/mongoinc/mongoInc-backup-0.1/mongodb-backup.config > $RPM_BUILD_ROOT/etc/mongobackup/ > ... > cp /home/ergunbilsel/PycharmProjects/mongoinc/mongoInc-backup-0.1/THANKS > $RPM_BUILD_ROOT/usr/share/doc/mongoInc-backup/ 1. Uh... this will fail when run anywhere else apart from your machine. 2. This is done in %prep, whereas it should be done in %install. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
