https://bugzilla.redhat.com/show_bug.cgi?id=1980562
--- Comment #3 from Ankur Sinha (FranciscoD) <[email protected]> --- (In reply to Jerry James from comment #2) > Running fedora-review against the F34 repo, because the Rawhide repo appears > to be a bit broken at the moment. Thanks for your review, Jerry. Upstream says the native R package should be preferred to the wrapper here, so I've dropped the R sub-package and I'll package that separately: https://cran.r-project.org/web/packages/Rcatch22/index.html > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > ===== Issues ==== > > - I'm struggling a bit with the license. > - LICENSE contains the text of GPLv3 > - wrap_Python/setup{,_P3}.py both identify the license as GPLv3 > - wrap_R/catch22/DESCRIPTION identifies the license as GPLv2+ > - All *.m files under Matlab identify the license as GPLv3+ > > Does this imply that the license for the main package and the python > wrapper > are GPLv3, but the R wrapper is GPLv2+, and the octave interface (not > currently built) is GPLv3+? It would appear so. I've added licenses to each sub-package now to make it clearer. > > - The python3 and R subpackages do not require the main package, so need to > contain a copy of the license file. Fixed > > - The gcc invocation near the top of %build both compiles and links, so > $LDFLAGS should be passed to gcc as well as $CFLAGS. Fixed > > - Regarding the SHOULD item "Packages should try to preserve timestamps of > original installed files", add -p to the cp invocations in %prep. Fixed. > > - rpmlint says: > R-catch22.x86_64: E: zero-length /usr/lib64/R/library/catch22/help/AnIndex > R-catch22.x86_64: E: zero-length > /usr/lib64/R/library/catch22/help/catch22.rdb > > Did something fail to be generated correctly? > R package dropped. Updated spec/srpm: Spec URL: https://ankursinha.fedorapeople.org/catch22/catch22.spec SRPM URL: https://ankursinha.fedorapeople.org/catch22/catch22-0.2.1-1.fc34.src.rpm * Mon Aug 09 2021 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 0.2.1-1 - Add sub-package specific licenses - Add LDFLAGS - Preserve time stamps - Remove R sub-package: package Rcatch22 separately - Run python test - Add basic C test -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
