https://bugzilla.redhat.com/show_bug.cgi?id=1989357
--- Comment #2 from Neal Gompa <ngomp...@gmail.com> ---
Initial review notes:
> %autosetup -p1 -n fedora-third-party-0.1
This should be "%autosetup -p1" or "%autosetup -p1 -n %{name}-%{version}" (the
-n stuff is optional since name-version matches the package name)
> %{python3_sitelib}/*
This is not allowed, you should use "%{python3_sitelib}/fedora_third_party*"
instead
Also, it seems to install a "tests" thing, which you shouldn't do. That
requires fixing setup.py accordingly:
https://pagure.io/fedora-third-party/blob/main/f/setup.py#_15
> %dnl This enables/adds any newly added repositories/remotes
> %transfiletriggerin -- %{_prefix}/lib/%{name}/conf.d
> fedora-third-party refresh
>
> %dnl This could potentially be used to remove Flatpak repositories (not
> currently implemented)
> %transfiletriggerpostun -- %{_prefix}/lib/%{name}/conf.d
> fedora-third-party refresh
"fedora-third-party refresh" should be "fedora-third-party refresh || :" so
that it won't fail if the package is uninstalled.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
