https://bugzilla.redhat.com/show_bug.cgi?id=1982647

Otto Urpelainen <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
              Flags|                            |needinfo?([email protected])



--- Comment #1 from Otto Urpelainen <[email protected]> ---
Reviewed, findings below:

1.
> This project is deprecated.

Where does this statement come from?
I cannot find any upstream reference.

2.
> Autoloader: %{_datadir}/php/%{ns_dir}/autoload.php

Format differently to look less like a specfile tag.

3. 
> : Remove leftover VCS files
> rm %{buildroot}%{_datadir}/php/%{ns_dir}/generated/Exceptions/.gitkeep

It would be good to submit a pull request to remove the file also from
upstream.

4.
The folder structure is somewhat strange,
with namespace being /usr/share/php/Safe
and having folders lib/, deprecated/ and generated/ under it.
I would have expected to see TheCodingMachine as the namespace.
However, given that this project extends the standard library,
perhaps doing it like that makes sense.
So I will just note this here,
I do not think any action is required here.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to