https://bugzilla.redhat.com/show_bug.cgi?id=1990158
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Doc Type|--- |If docs needed, set a value Flags| |fedora-review? Assignee|[email protected] |[email protected] --- Comment #2 from Fabio Valentini <[email protected]> --- Taking this review. Some small blockers: - open a PR with upstream about updating your patched dependencies and/or link the PR in the spec file - explain why you need to "sed" the tests/test.rs file (also, this test should probably use something like `env!("CARGO_TARGET_DIR")` (don't quote me on that) instead of hard-coding "target/debug" or "target/release" ...) - why is the "test_backtrace" test disabled? Minor nitpicks: - leave the generated "# Initial patched metadata" comment in the .spec file - drop "examples" and maybe even "CONTRIBUTING.md" from "%doc", both are pretty useless for RPM packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
