https://bugzilla.redhat.com/show_bug.cgi?id=2002848



--- Comment #3 from Ankur Sinha (FranciscoD) <[email protected]> ---
Thanks very much for the review Zbigniew!

(In reply to Zbigniew Jędrzejewski-Szmek from comment #2)
> > The full documentation is available at http://docs.datalad.org and
> > http://handbook.datalad.org provides a hands-on crash-course on DataLad
> > https://neurostars.org/tag/datalad
> 
> https:// seems to work everywhere.

Updated all links to use https

> 
> > All bugs, concerns, and enhancement requests for this software can be 
> > submitted
> > here: https://github.com/datalad/datalad/issues
> 
> I don't think we want to direct *all* issue there. Maybe say that for
> packaging
> issues, bugzilla should be used, but there's also an upstream bugtracker…

I've just removed that line. The main documentation at datalad.org already
notes their GitHub etc. 

> 
> > %package -n python3-datalad
> 
> I think it's appropriate to call this with the python3- prefix, since it's
> provides a python module, and people might use that module from other code.
> But maybe add "Provides: datalad" to match the executable name?

Added.

> 
> + package name is OK
> + license is acceptable for Fedora (MIT)
> + license is specified correctly (*)
> + builds and installs OK
> + BR/R/P look correct
> + fedora-review is happy
> + rpmlint shows only bogus spelling complaints, as usual
> 
> (*) There's a GPLv3 file in sources, but it doesn't appear in the built
> package.
> 
> Package is APPROVED.

Cheers,

Requested SCM now.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to