https://bugzilla.redhat.com/show_bug.cgi?id=2001699



--- Comment #4 from Emmanuel Seyman <[email protected]> ---
(In reply to Jitka Plesnikova from comment #3):
>
> TODO: Move 'perl(Test::TCP)' from runtime BR to test BR

Done.

> FIX: Please add to command 'perl Makefile.PL' options 'NO_PACKLIST=1
> NO_PERLLOCAL=1'

Hummm... Not sure how I missed that one, TBH. Fixed.

> Otherwise the package is in line with Fedora and Perl packaging guide lines.
> Please correct all 'FIX' item, consider fixing 'TODO' item.

Spec URL:
https://people.parinux.org/~seyman/fedora/perl-Web-Machine/perl-Web-Machine.spec
SRPM URL:
https://people.parinux.org/~seyman/fedora/perl-Web-Machine/perl-Web-Machine-0.17-2.fc34.src.rpm

> Resolution:
> Approved

Thank you for the review, Jikta.
Repository requested
(https://pagure.io/releng/fedora-scm-requests/issue/37008).


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2001699
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to