https://bugzilla.redhat.com/show_bug.cgi?id=1999177



--- Comment #3 from Didik Supriadi <[email protected]> ---
(In reply to Robert Scheck from comment #2)
> As mentioned in bug #2000976, I'm not experienced in Java (packaging), I've
> read https://docs.fedoraproject.org/en-US/java-packaging-howto/manpages/,
> and I'll try to review this...hopefully.
> 
> > %pom_xpath_inject pom:project '<groupId>com.github.stefanbirkner</groupId>'
> > %pom_remove_plugin :animal-sniffer-maven-plugin
> > %pom_add_dep org.apache.commons:commons-lang3
> > %pom_xpath_inject 
> > 'pom:project/pom:build/pom:plugins/pom:plugin[pom:artifactId="maven-surefire-plugin"]'
> >  '<version>any</version>'
> 
> Why are these POM changes needed? Does it make sense to put the
> reason/explanation into comments inside the spec file?

I've fixed some issues and added explanations for each pom_*

Spec URL: https://didiksupriadi41.fedorapeople.org/system-rules.spec
SRPM URL:
https://didiksupriadi41.fedorapeople.org/system-rules-1.19.0-2.fc34.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1999177
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to