https://bugzilla.redhat.com/show_bug.cgi?id=2006590
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra |needinfo?([email protected] |in.net) |) --- Comment #2 from Ben Beasley <[email protected]> --- Thanks for the review! > - Dist tag is present. > Fedora-review reports a dist tag presence, but it seems a false positive and > can be ignored. It’s actually confusingly trying to complain that the dist tag is not present, but it’s because it does not understand rpmautospec. It’s just looking for the %{?dist} macro in Release, and doesn’t understand that %autorelease includes the dist tag. > - Architecture-specific "devel" packages are actually identical: they provide > the same "earcut.hpp" source file version. > The difference is in the testing suite flow, but for an end-user they all > provide the same content. > Please consider changing devel package to "noarch". This seems reasonable—especially leaving the base package arched to run the tests on all architectures, while marking the -devel subpackage noarch—and I have used this approach on Python packages that have no compiled code but are prone to arch-dependent test failures. However, for header-only library packages like this one, the guidelines actually forbid using noarch: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_do_not_use_noarch -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2006590 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
