https://bugzilla.redhat.com/show_bug.cgi?id=2010053



--- Comment #6 from Ankur Sinha (FranciscoD) <[email protected]> ---
Thanks for your reviews.

- you can ignore the "dist tag" warning---our checks don't know about
`%autorelease` yet.
- you can ignore the changelog warning---our checks don't know about
`%autochangelog` yet.

Changes to the spec:

- updated to use the 0.2.0 release
- the developers don't include the LICENSE file in the pypi tar.gz, so I'm
using the copy they have on the GitHub repository instead. This is now included
in the rpm:
$ rpm -ql --licensefiles -p
results_python-sphinxemoji/0.2.0/1.fc36/python3-sphinxemoji-0.2.0-1.fc36.noarch.rpm
 
/usr/lib/python3.10/site-packages/sphinxemoji-0.2.0.dist-info/LICENSE

New spec/srpm:

Spec URL:
https://ankursinha.fedorapeople.org/python-sphinxemoji/python-sphinxemoji.spec
SRPM URL:
https://ankursinha.fedorapeople.org/python-sphinxemoji/python-sphinxemoji-0.2.0-1.fc36.src.rpm

Please feel free to do another round of reviews to verify if there's anything
else that needs fixing.

Shane, could you also complete your review and see if this is ready for
approval please?

Thanks,
Ankur


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2010053
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to