https://bugzilla.redhat.com/show_bug.cgi?id=2010718

Artur Frenszek-Iwicki <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([email protected] |
                   |)                           |



--- Comment #7 from Artur Frenszek-Iwicki <[email protected]> ---
The sources used to build the linked SRPM do not match the upstream tarball
that's specified as Source0.
Please rebuild the package and then I'll review it.

Some quick notes in the meantime:

In the spec:
> %files
> %{_datadir}/%{name}/*
This will make the package own files inside /usr/share/alizams, but not the
directory itself.
https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/#_wildcarding_files_inside_a_created_directory

rpmlint messages:
> alizams.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 13)
There's a tab between the "URL:" tag and its value.

> E: specfile-error warning: bogus date in %changelog: Sun Oct 20 2021 
Oct 20 was a Wednesday.

In alizams.appdata.xml:
>   <screenshot type="default">
>     
> <image>https://lh6.googleusercontent.com/gIyaJlPe0i6ZnjKCt4SlshvHG1b9KItl_4DEShBjXx2d5dHXO7f_vQw-UeobzMysC-2iBAqKf03H1ooobNbTfouXoLAHE2GU6mr3hz55W62NqTGt5mmYnSSG2Cltfr9zVA=w1280</image>
>   </screenshot>
This link gives me a 403.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2010718
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to