https://bugzilla.redhat.com/show_bug.cgi?id=2022991



--- Comment #8 from Oleg Girko <[email protected]> ---
(In reply to Vitaly Zaitsev from comment #6)
> > BuildRequires:  cmake3
> 
> BuildRequires: cmake should be used on Fedora.

It's exactly the same for Fedora because cmake package version 3 provides
cmake3 capability.
But it doesn't work for CentOS 7 where cmake and cmake3 are different packages.
And I still insist on using the same spec file for Fedora's Koji and my OBS
where I build for CentOS 7 as well.

> > %setup -q
> 
> Can be replaced with %autosetup.

As I don't use patches, there's no difference.
May be I'll consider using %autosetup later, if patches are needed.

> > %files
> 
> You must also include license: %license LICENSE.

Done.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2022991
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to