https://bugzilla.redhat.com/show_bug.cgi?id=2026516

Artur Frenszek-Iwicki <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
           Doc Type|---                         |If docs needed, set a value



--- Comment #3 from Artur Frenszek-Iwicki <[email protected]> ---
> Summary:      This is a SIP honeypot for VoIP
"This is a" is a bit redundant. Simply "SIP honeypot for VoIP" will suffice.

> %install
> rm -rf $RPM_BUILD_ROOT
Don't do this.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

> %files
> %{_mandir}/man1/%{name}.1.gz
Do not assume man pages will be gzipped. Use a wildcard that can match any
compression method (including no compression at all).
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2026516
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to