https://bugzilla.redhat.com/show_bug.cgi?id=2033890
--- Comment #6 from Fabio Valentini <[email protected]> --- (In reply to Arthur Bols from comment #5) > > Is this really a problem? > > I usually translate meson dev library requirements into BuildRequires 1:1 > > so I don't miss any constraints from upstream, so I'd like to keep them > > there. > > It's recommended (SHOULD) in the packaging guidelines [0], but since you > have a decent justification, it's fine for me. Well, technically, the guidelines say "three previous Fedora releases", which would include Fedora 33, which does *not* satisfy all those requirements. ;) > > This *is* weird. I have asked upstream why they install icons for double > > pixel density if they are just duplicates, and that the hicolor icon theme > > apparently does not supprt @2 at all: > > https://github.com/elementary/tasks/issues/321 > > I searched a bit further and it seems it's used for hi-resolution displays, > but the way it's used here is wrong (I think). hicolor-icon-theme apparently > does support @2, it's a bit vague in the spec [1] and I don't understand why > they "fixed" it in 0.16 by adding it to the index.theme file but didn't > change the build to create the directories... There also seems to be an > oversight by adding arbitrary scaling support in the spec, but only > supporting @2 and not @3... It seems that this was an oversight in the original patch that added @2 scaling support to index.theme: https://gitlab.freedesktop.org/xdg/default-icon-theme/-/issues/2 (issue opened in 2018 by another Fedora packager ...) > GammaRay seems to do it correctly [2] and [3], but the directories are still > not owned by anything. They use @2 and @3, but since hicolor-icon-theme only > supports @2, I'm not sure if @3 would even do anything but wasting space. > > Also, this issue is actually present for many elementary packages, but first > let's see how this problem is solved upstream. > > If you'd like the package to approved, I think it's fine to remove the @2 > directories (since they are just the same icons and thus shouldn't do > anything) and add a comment linking to the upstream issue. You're right. I'll probably remove the NxN@2 icons for now and add these links: https://github.com/elementary/tasks/issues/321 https://gitlab.freedesktop.org/xdg/default-icon-theme/-/issues/2 https://bugzilla.redhat.com/show_bug.cgi?id=1537318 https://src.fedoraproject.org/rpms/hicolor-icon-theme/pull-request/2 === Updated spec and SRPM behind the same URLs. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2033890 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
