https://bugzilla.redhat.com/show_bug.cgi?id=2040624



--- Comment #3 from Ben Beasley <[email protected]> ---
This is not quite true:

> # Test suite needs dependencies not in Fedora.

----

In fact, we can add:

> %global data_commit 1e4c5061d328105c4dcfcb6fdbc27ec49b3e9d23
> # This contains bundled fonts for testing, but they are *not* installed
> Source1:        
> https://github.com/adobe-type-tools/psautohint-testdata/archive/%{data_commit}/psautohint-testdata-%{data_commit}.tar.gz

and

> BuildRequires:  /usr/bin/tx

(which reduces the number of skipped tests)

and then to make sure all the functionality is available by default, in
python3-psautohint:

> Recommends:     /usr/bin/tx

Then, in %prep:

> %autosetup -p1 -n %{tarball_name}-%{version}
> rm -vrf tests/integration/data
> %setup -q -n %{tarball_name}-%{version} -T -D -b 1
> mv ../psautohint-testdata-%{data_commit}/ tests/integration/data
> # Allow newer versions of testing dependencies
> sed -r -i 's/("pytest[^[:blank:]]*) >=[^"]+/\1/' setup.py
> # Drop pytest-randomly, which doesn’t seem to be mandatory,
> # and pytest-cov, since we do not need coverage analysis
> sed -r -i '/pytest-(randomly|cov)/d' setup.py

The only missing dependency was python3dist(pytest-randomly), which as
mentioned above doesn’t actually seem to be required. Then:

> %pyproject_buildrequires -x testing

and

> k="${k-}${k+ and }not test_hashmap_old_version'
> %pytest -k "${k-}"

At least in a local mock build on x86_64, that results in all the tests running
and passing, except for the one I skipped. I haven’t looked into why it fails.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2040624
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to