https://bugzilla.redhat.com/show_bug.cgi?id=2037645
José Matos <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #25 from José Matos <[email protected]> --- Thank you for all the changes. I was worried with the python3 sub-package dependencies but I see that they are already met. The only remaining concern is to have a %check section to ensure that all the tests pass. Eventually, without checking, I would expect this to be simply: %check %scons test insert this before the %file section. Sometimes this can require new packages to build but it has the advantage that it catches failures when building the package. OK, tested locally and it works: " print_report(["test_results"], []) ***************************** *** Testing Summary *** ***************************** Tests passed: 1659 Up-to-date tests skipped: 0 Tests failed: 0 ***************************** " In any case I trust you to try this after importing the package. So here follows the formal review: The license is correct, appropriated and included in the package. The package follows the fedora name scheme and is according to the Fedora guidelines. So the package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2037645 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
