https://bugzilla.redhat.com/show_bug.cgi?id=2034723



--- Comment #5 from Ankur Sinha (FranciscoD) <[email protected]> ---
Note: there's an issue here that needs correcting as noted in the review:

Requires: python-toml-adapt -> Requires: python3-toml-adapt

or: Requires: %{py3_dist toml-adapt}

It needs to be a versioned requirement.

- I also see that the debuginfo is disabled. Please enable it. Only if no
useful debuginfo can be generated should it be explicitly disabled:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_debuginfo_packages

- Best to document the reason behind the patch as a comment
- python3-devel now pulls in pyproject-rpm-macros, so the explicit BR can be
dropped


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2034723
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to