https://bugzilla.redhat.com/show_bug.cgi?id=2051008



--- Comment #23 from Dominik 'Rathann' Mierzejewski <[email protected]> ---
Note that when linking with fdk-aac-free, you need to disable all GPL codecs as
FDK-AAC license is GPL-incompatible (but LGPL-compatible).

Here's the list:
%global _without_amr      1
%global _without_cdio     1
%global _without_frei0r   1
%global _without_gmp      1
%global _without_gpl      1
%global _without_lensfun  1
%global _without_rubberband 1
%global _without_smb      1
%global _without_vidstab  1
%global _without_vmaf     1
%global _without_x264     1
%global _without_x265     1
%global _without_xvid     1


Now, this part:
    --disable-parser="h263,h264,hevc,vc1" \
    --enable-muxers \
    --disable-muxer="mp4,h263,h264,hevc,vc1" \
    --enable-demuxers \
    --disable-demuxer="mp4,h263,h264,hevc,vc1" \
    --disable-encoders \
    --disable-decoders \
    --disable-decoder="mpeg4,h263,h264,hevc,vc1" \

I think this will break all hardware en/decoders. You need to keep parsers and
(de)muxers enabled. Considering mkvtoolnix and other tools which can parse and
demux the above are in Fedora already, this should be legal to do.

Also, there's no point in disabling the specific set of decoders if you have
--disable-decoders in the line above.

# Paranoia check
%if %{without all_codecs}
for i in MPEG4 H263 H264 HEVC VC1; do
    grep -q "#define CONFIG_${i}_DECODER 0" config.h
done
%endif

You're forgetting about encoders. ;)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2051008
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to