https://bugzilla.redhat.com/show_bug.cgi?id=2045079



--- Comment #2 from Neal Gompa <[email protected]> ---
Initial spec review:

> Requires(pre):  /usr/sbin/useradd

Your scriptlet has more programs in here, you probably should list them.
Alternatively, I believe all the programs are part of shadow-utils, and you can
switch to that package name instead.

> %_prefix/lib/systemd/system-generators/quadlet-system-generator
> %_prefix/lib/systemd/user-generators/quadlet-user-generator

Please BuildRequires: systemd-rpm-macros and use the correct macros here:

%{_systemdgeneratordir}/quadlet-system-generator
%{_systemdusergeneratordir}/quadlet-user-generator


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2045079
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to