Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=669910

Zachary Doherty <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #2 from Zachary Doherty <[email protected]> 2011-01-18 04:46:48 
EST ---
I'm new to this so I don't want to be the official reviewer, however I will do
my best to do an "unofficial" review.

- Upstream simply licenses todo.txt_cli as GPL, according to Fedora's licensing
guidelines this means it is licensed under *any* version of the GPL. Your
package licenses it under GPLv1 incorrectly (it should be GPL+ instead).

That is the only thing I see wrong with MUST requirements. In regards to
non-mandatory SHOULD guidelines:

- Upstream should be queried to include license text with their releases.
- Work with upstream to get man pages included.

Those are the only problems I saw while looking through your package. Like I
said, I'm new to doing package reviews so it's pretty likely that I missed
something.

--Zach

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to