https://bugzilla.redhat.com/show_bug.cgi?id=2041471



--- Comment #4 from Jarek Prokop <[email protected]> ---
There are a few nits:

* As mentioned the package should have a bundled provide of the JS library.

* The BuildRequires section has triplicated mentions of Ruby -- specifically of
`ruby`, `ruby(release)`, and `ruby >= 2.7.0`.

* There is a newer version available: 1.0.2, which should be preferably
packaged.

Otherwise LGTM.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2041471
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to