Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=670457 Jeffrey Ness <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Jeffrey Ness <[email protected]> 2011-01-18 14:46:05 EST --- Hello Zachary, This is a unofficial review as I am still seeking sponsorship myself, but I noticed a few things worth mentioning: * Your SPEC should use macros where ever possible, your Source0 line should use %{name} and %{version} (this will make version upgrades easier). http://fedoraproject.org/wiki/Packaging/ReviewGuidelines MUST: Each package must consistently use macros. [16] * Under %files you are listing all files under /usr/share/man/man1/ (this could overlap with Build Dependencies and should be more specific). %doc %{_mandir}/man1/toilet.1.gz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
