https://bugzilla.redhat.com/show_bug.cgi?id=2009666



--- Comment #7 from Artur Frenszek-Iwicki <[email protected]> ---
> %define ver 3.2
> %define rel 1%{?dist}
Any reason for introducing these macros instead of just putting the values
inside Version: and Release: tags?

> %define prefix /usr
This doesn't seem to be used anywhere.

> %description
> 
> gdcalc is a financial, statistics, scientific and programmers
> calculator for gtk+-based under Unix and Linux.
Please remove the empty line at the start.

> gdcalc is based on my venerable dcalc RPN calculator which I wrote a
> million years ago to learn C and curses - about 1983, I suppose.
This is nice for a README, but seems a bit off when used as part of the package
description.

> %files
> %{_datadir}/icons/hicolor/48x48/apps/*
This necessitates "Requires: hicolor-icon-theme".


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2009666
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to