https://bugzilla.redhat.com/show_bug.cgi?id=2051212

Aleksei Bavshin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
              Flags|                            |fedora-review+
             Status|NEW                         |POST
           Assignee|[email protected]    |[email protected]



--- Comment #2 from Aleksei Bavshin <[email protected]> ---
 - The `vtune` optional feature depends on `wasmtime-jit/vtune` which you've
already removed and is broken. Please, update the metadata patch to remove it
(it's fine to do that before import).
    % rg --glob Cargo.toml vtune
   
2051212-rust-wasmtime/rpms-unpacked/rust-wasmtime-devel-0.33.0-1.fc37.noarch.rpm/usr/share/cargo/registry/wasmtime-0.33.0/Cargo.toml
    126:vtune = ["wasmtime-jit/vtune"]
 - Deprecation warning is already fixed in v0.34.0.

LGTM

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2051212
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to