https://bugzilla.redhat.com/show_bug.cgi?id=2043940



--- Comment #6 from Justin Zobel <[email protected]> ---
- Include the licenses folder in %files

- With regards to desktop-file-validate only 2 of the 4 fail, the others should
be able to be validated and the make note that the others have been reported
upstream:
./usr/share/plasma/packages/org.kde.plasma.nano.desktoptoolbox/metadata.desktop:
error: file contains multiple keys named "X-KDE-PluginInfo-Version" in group
"Desktop Entry"
./usr/share/kservices5/plasma-package-org.kde.plasma.nano.desktoptoolbox.desktop:
error: file contains multiple keys named "X-KDE-PluginInfo-Version" in group
"Desktop Entry"

find . -iname "*.desktop"
./usr/share/plasma/shells/org.kde.plasma.nano/metadata.desktop
./usr/share/plasma/packages/org.kde.plasma.nano.desktoptoolbox/metadata.desktop
./usr/share/kservices5/plasma-package-org.kde.plasma.nano.desktoptoolbox.desktop
./usr/share/kservices5/plasma-applet-org.kde.plasma.nano.desktop

- Make note in %files section that unversioned so file is required (confirmed
by upstream)

- The review.txt mentions some folders aren't owned by the package, I assume
because they're not listed in the %files section:
     /usr/lib64/qt5/qml/org/kde/plasma/private/nanoshell
     /usr/lib64/qt5/qml/org/kde/plasma/private/nanoshell/qml
     /usr/share/plasma/packages/org.kde.plasma.nano.desktoptoolbox
     /usr/share/plasma/packages/org.kde.plasma.nano.desktoptoolbox/contents
     /usr/share/plasma/packages/org.kde.plasma.nano.desktoptoolbox/contents/ui
     /usr/share/plasma/shells/org.kde.plasma.nano
     /usr/share/plasma/shells/org.kde.plasma.nano/contents
     /usr/share/plasma/shells/org.kde.plasma.nano/contents/applet
     /usr/share/plasma/shells/org.kde.plasma.nano/contents/configuration
     /usr/share/plasma/shells/org.kde.plasma.nano/contents/explorer
     /usr/share/plasma/shells/org.kde.plasma.nano/contents/views


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2043940
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to