https://bugzilla.redhat.com/show_bug.cgi?id=2076825

Neal Gompa <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+
                 CC|                            |[email protected]
             Status|NEW                         |POST
           Assignee|[email protected]    |[email protected]



--- Comment #1 from Neal Gompa <[email protected]> ---
Review notes:

* Package outputs are the same before and after
* Packaging follows packaging guidelines
* Package licensing is correct and license files are installed properly

Nits:

* There's a missing "%bcond_with tests" definition to go with the
"%bcond_without tests" one.
* The usage of "%if %{defined ...}" is a bit unconventional, but fine.

In any case...

PACKAGE APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2076825
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to