https://bugzilla.redhat.com/show_bug.cgi?id=2073377

Paul Howarth <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([email protected] |
                   |)                           |



--- Comment #2 from Paul Howarth <[email protected]> ---
(In reply to Michal Josef Spacek from comment #1)
> @[email protected] 
> 
> "BuildRequires:  coreutils"
> It is not needed, sure?

%{_fixperms} in the %install section is implemented using chmod from coreutils.

> "BuildRequires:  perl(strict)"
> You could move to "Module Runtime" section

Yes, you're right, it should be there.

> "%doc Changes README t/"
> No contain t/ in doc

I don't usually package the tests. It's a habit from a long time ago when you
could get additional dependencies from documentation files.
I'm open to persuasion on this.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2073377
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to