https://bugzilla.redhat.com/show_bug.cgi?id=2073629



--- Comment #4 from Davide Cavalca <[email protected]> ---
%if %{with check}
# Tests
BuildRequires:  golang(github.com/DATA-DOG/go-sqlmock)
# BuildRequires:  golang(github.com/google/uuid)
# BuildRequires:  golang(github.com/gorilla/websocket)
BuildRequires:  golang(github.com/jessevdk/go-flags)
BuildRequires:  golang(github.com/json-iterator/go)
# BuildRequires:  golang(github.com/modern-go/reflect2)
BuildRequires:  golang(github.com/stretchr/testify/assert)
BuildRequires:  golang(github.com/stretchr/testify/mock)
BuildRequires:  golang(github.com/stretchr/testify/require)
BuildRequires:  golang(golang.org/x/tools/go/packages/packagestest)
# BuildRequires:  golang(go.opencensus.io/stats/view)
# BuildRequires:  golang(go.opencensus.io/trace)
%endif

Why the commented BRs?

# goimport fails to pick up these

Should we file a bug on the golang macros for this?

%generate_buildrequires
# %%go_generate_buildrequires

I think you have some debugging leftover here

%doc doc examples README.md README_jp.md CODE_OF_CONDUCT.md CONTRIBUTING.md
%doc README_zh.md entc/integration/README.md doc

entc/integration/README.md will overwrite the top-level readme; either drop it
from %doc (and from godocs), or rename it to something else first


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2073629
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to