https://bugzilla.redhat.com/show_bug.cgi?id=2074709



--- Comment #6 from Neal Gompa <[email protected]> ---
Spec review:

> %global rpm_macros_dir %(d=%{_rpmconfigdir}/macros.d; [ -d $d ] || 
> d=%{_sysconfdir}/rpm; echo $d)

Just get rid of all this and use %{_rpmmacrodir} wherever %{rpm_macros_dir} was
used.

> #patch0 -p1

Drop this, it's unused.

>   --qmake-setting 'QMAKE_CFLAGS_RELEASE="%{optflags}"' \
>   --qmake-setting 'QMAKE_CXXFLAGS_RELEASE="%{optflags} `pkg-config --cflags 
> dbus-python`"' \
>   --qmake-setting 'QMAKE_LFLAGS_RELEASE="%{?__global_ldflags}"'

Use %{build_cflags}, %{build_cxxflags}, and %{build_ldflags} accordingly.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2074709
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to